fix(arrow/scalar): handle nil child values in run-end scalars - #1001
Merged
zeroshade merged 2 commits intoJul 27, 2026
Merged
Conversation
fallintoplace
changed the title
fallintoplace
changed the title
fallintoplace
changed the title
zeroshade
approved these changes
Jul 27, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Verified: `MakeNullScalar` for a run-end encoded type leaves `Value == nil`, and `RunEndEncoded.Validate` dereferenced it immediately — I reproduced the nil-pointer panic. Handling the missing child explicitly (accept for null scalars, error for a non-null scalar with no value) is correct. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakeNullScalarcreates a null run-end encoded scalar without a child value.RunEndEncoded.Validatedereferenced that value before checking nullness, so validation could panic.This handles the missing child explicitly: null scalars are accepted, malformed non-null scalars still fail, and both paths are covered by tests.
Tests:
go test ./arrow/scalar